From 9a104b918c723df53455eadec4d370ef0a9c142c Mon Sep 17 00:00:00 2001
From: Huang Xin <chrox.huang@gmail.com>
Date: Wed, 19 Mar 2025 11:22:15 +0800
Subject: [PATCH] fix: dismiss popup footnotes on window resize, also closes
 #634 and closes #635 (#638)

---
 .../app/reader/components/FootnotePopup.tsx   | 27 ++++++++++---------
 apps/readest-app/src/utils/style.ts           |  9 ++++---
 2 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/apps/readest-app/src/app/reader/components/FootnotePopup.tsx b/apps/readest-app/src/app/reader/components/FootnotePopup.tsx
index ac02d20f..caf907e2 100644
--- a/apps/readest-app/src/app/reader/components/FootnotePopup.tsx
+++ b/apps/readest-app/src/app/reader/components/FootnotePopup.tsx
@@ -26,9 +26,8 @@ const FootnotePopup: React.FC<FootnotePopupProps> = ({ bookKey, bookDoc }) => {
   const [popupPosition, setPopupPosition] = useState<Position | null>();
   const [showPopup, setShowPopup] = useState(false);
 
-  const { getView, getProgress, getViewSettings } = useReaderStore();
+  const { getView, getViewSettings } = useReaderStore();
   const view = getView(bookKey);
-  const progress = getProgress(bookKey)!;
   const viewSettings = getViewSettings(bookKey)!;
   const footnoteHandler = new FootnoteHandler();
 
@@ -36,6 +35,11 @@ const FootnotePopup: React.FC<FootnotePopupProps> = ({ bookKey, bookDoc }) => {
   const [responsiveWidth, setResponsiveWidth] = useState(popupWidth);
   const [responsiveHeight, setResponsiveHeight] = useState(popupHeight);
 
+  const getResponsivePopupSize = (size: number, isVertical: boolean) => {
+    const maxSize = isVertical ? window.innerWidth / 2 : window.innerHeight / 2;
+    return Math.min(size, maxSize - popupPadding - 12);
+  };
+
   useEffect(() => {
     const handleBeforeRender = (e: Event) => {
       const detail = (e as CustomEvent).detail;
@@ -75,9 +79,9 @@ const FootnotePopup: React.FC<FootnotePopupProps> = ({ bookKey, bookDoc }) => {
       view.addEventListener('relocate', () => {
         const { renderer } = view as FoliateView;
         if (viewSettings.vertical) {
-          setResponsiveWidth(Math.min(renderer.viewSize, window.innerWidth / 2));
+          setResponsiveWidth(getResponsivePopupSize(renderer.viewSize, true));
         } else {
-          setResponsiveHeight(Math.min(renderer.viewSize, window.innerHeight / 2));
+          setResponsiveHeight(getResponsivePopupSize(renderer.viewSize, false));
         }
         setShowPopup(true);
       });
@@ -92,17 +96,12 @@ const FootnotePopup: React.FC<FootnotePopupProps> = ({ bookKey, bookDoc }) => {
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [view]);
 
-  useEffect(() => {
-    handleDismissPopup();
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [progress]);
-
   useEffect(() => {
     if (viewSettings.vertical) {
       setResponsiveWidth(popupHeight);
-      setResponsiveHeight(Math.max(360, window.innerHeight / 4));
+      setResponsiveHeight(Math.max(popupWidth, window.innerHeight / 4));
     } else {
-      setResponsiveWidth(Math.max(360, window.innerWidth / 4));
+      setResponsiveWidth(Math.max(popupWidth, window.innerWidth / 4));
       setResponsiveHeight(popupHeight);
     }
   }, [viewSettings]);
@@ -173,9 +172,9 @@ const FootnotePopup: React.FC<FootnotePopupProps> = ({ bookKey, bookDoc }) => {
       document.body.appendChild(elem);
       const popupSize = elem.getBoundingClientRect();
       if (viewSettings.vertical) {
-        setResponsiveWidth(Math.min(popupSize.width, window.innerWidth / 2));
+        setResponsiveWidth(getResponsivePopupSize(popupSize.width, true));
       } else {
-        setResponsiveHeight(Math.min(popupSize.height, window.innerHeight / 2));
+        setResponsiveHeight(getResponsivePopupSize(popupSize.height, false));
       }
       document.body.removeChild(elem);
 
@@ -192,8 +191,10 @@ const FootnotePopup: React.FC<FootnotePopupProps> = ({ bookKey, bookDoc }) => {
   });
 
   useEffect(() => {
+    window.addEventListener('resize', handleDismissPopup);
     eventDispatcher.on('footnote-popup', handleFootnotePopupEvent);
     return () => {
+      window.removeEventListener('resize', handleDismissPopup);
       eventDispatcher.off('footnote-popup', handleFootnotePopupEvent);
     };
     // eslint-disable-next-line react-hooks/exhaustive-deps
diff --git a/apps/readest-app/src/utils/style.ts b/apps/readest-app/src/utils/style.ts
index bac59ffe..c2bdc541 100644
--- a/apps/readest-app/src/utils/style.ts
+++ b/apps/readest-app/src/utils/style.ts
@@ -253,10 +253,13 @@ export const getFootnoteStyles = () => `
     padding: 0;
   }
 
-  p, li, blockquote, dd {
+  body {
     padding: 1em !important;
-    margin: 0 !important;
-    text-indent: 0 !important;
+  }
+
+  p, li, blockquote, dd {
+    margin: unset;
+    text-indent: unset;
   }
 `;