From 8a4e22e423597068feb66995993985c2af159410 Mon Sep 17 00:00:00 2001 From: Huang Xin Date: Fri, 19 Dec 2025 10:45:42 +0800 Subject: [PATCH] refactor: temporarily disable the proofreading feature for a hotfix release ahead of a major refactor (#2742) --- .../ReplacementRulesWindow.test.tsx | 2 +- .../components/annotator/AnnotationPopup.tsx | 24 +++++++++++-------- .../reader/components/annotator/Annotator.tsx | 1 + .../components/annotator/TranslatorPopup.tsx | 17 +++++++------ .../reader/components/sidebar/BookMenu.tsx | 2 +- 5 files changed, 25 insertions(+), 21 deletions(-) diff --git a/apps/readest-app/src/__tests__/components/ReplacementRulesWindow.test.tsx b/apps/readest-app/src/__tests__/components/ReplacementRulesWindow.test.tsx index 63878cfc..b8c170df 100644 --- a/apps/readest-app/src/__tests__/components/ReplacementRulesWindow.test.tsx +++ b/apps/readest-app/src/__tests__/components/ReplacementRulesWindow.test.tsx @@ -72,7 +72,7 @@ function renderWithProviders(ui: React.ReactNode) { return render({ui}); } -describe('ReplacementRulesWindow', () => { +describe.skip('ReplacementRulesWindow', () => { beforeEach(() => { // Reset stores (useSettingsStore.setState as unknown as (state: unknown) => void)({ diff --git a/apps/readest-app/src/app/reader/components/annotator/AnnotationPopup.tsx b/apps/readest-app/src/app/reader/components/annotator/AnnotationPopup.tsx index 68734b0d..29f0486b 100644 --- a/apps/readest-app/src/app/reader/components/annotator/AnnotationPopup.tsx +++ b/apps/readest-app/src/app/reader/components/annotator/AnnotationPopup.tsx @@ -15,6 +15,7 @@ interface AnnotationPopupProps { Icon: React.ElementType; onClick: () => void; disabled?: boolean; + visible?: boolean; }>; position: Position; trianglePosition: Position; @@ -65,16 +66,19 @@ const AnnotationPopup: React.FC = ({ )} style={{ scrollbarWidth: 'none', msOverflowStyle: 'none' }} > - {buttons.map((button, index) => ( - - ))} + {buttons.map((button, index) => { + if (button.visible === false) return null; + return ( + + ); + })} {highlightOptionsVisible && ( diff --git a/apps/readest-app/src/app/reader/components/annotator/Annotator.tsx b/apps/readest-app/src/app/reader/components/annotator/Annotator.tsx index f9015fa6..0dc8ba7d 100644 --- a/apps/readest-app/src/app/reader/components/annotator/Annotator.tsx +++ b/apps/readest-app/src/app/reader/components/annotator/Annotator.tsx @@ -965,6 +965,7 @@ const Annotator: React.FC<{ bookKey: string }> = ({ bookKey }) => { Icon: MdBuildCircle, onClick: handleShowReplacementOptions, disabled: bookData.book?.format !== 'EPUB', + visible: false, }, ]; diff --git a/apps/readest-app/src/app/reader/components/annotator/TranslatorPopup.tsx b/apps/readest-app/src/app/reader/components/annotator/TranslatorPopup.tsx index 5b029af3..1fb4efb3 100644 --- a/apps/readest-app/src/app/reader/components/annotator/TranslatorPopup.tsx +++ b/apps/readest-app/src/app/reader/components/annotator/TranslatorPopup.tsx @@ -202,15 +202,14 @@ const TranslatorPopup: React.FC = ({ )}
- {provider && !loading && ( -
- {error - ? '' - : _('Translated by {{provider}}.', { - provider: providers.find((p) => p.name === provider)?.label, - })} -
- )} +
+ {provider && + !loading && + !error && + _('Translated by {{provider}}.', { + provider: providers.find((p) => p.name === provider)?.label, + })} +