refactor(share): make saveFile content nullable for path-based shares (#4424)

The book "Send" flow had to pass `new ArrayBuffer(0)` to saveFile purely to
satisfy the type-checker: the content arg is ignored on the native share
path when `options.filePath` points at an already-on-disk file. Widen
saveFile's content parameter to `string | ArrayBuffer | null` across the
AppService contract so callers can hand off a file by path without buffering
it into memory, and pass `null` from the Send flow instead of a throwaway
empty buffer.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Huang Xin
2026-06-02 22:49:47 +08:00
committed by GitHub
parent df66c63a07
commit e4bb9fc4b7
7 changed files with 40 additions and 14 deletions
@@ -633,7 +633,7 @@ export class NativeAppService extends BaseAppService {
async saveFile(
filename: string,
content: string | ArrayBuffer,
content: string | ArrayBuffer | null,
options?: {
filePath?: string;
mimeType?: string;
@@ -655,7 +655,7 @@ export class NativeAppService extends BaseAppService {
shareablePath = await this.resolveFilePath(filename, 'Temp');
if (typeof content === 'string') {
await writeTextFile(shareablePath, content);
} else {
} else if (content) {
await writeFile(shareablePath, new Uint8Array(content));
}
}
@@ -688,7 +688,7 @@ export class NativeAppService extends BaseAppService {
if (typeof content === 'string') {
await writeTextFile(filePath, content);
} else {
} else if (content) {
await writeFile(filePath, new Uint8Array(content));
}
return true;