From f0ab05bbdecfccf9e57ec3a9b9e06e578f264724 Mon Sep 17 00:00:00 2001 From: Huang Xin Date: Wed, 1 Apr 2026 22:44:52 +0800 Subject: [PATCH] chore(agent): update agent skills and memories (#3721) --- apps/readest-app/.claude/memory/MEMORY.md | 2 ++ .../.claude/memory/feedback_gstack_upgrade.md | 11 +++++++++++ .../.claude/memory/feedback_pr_new_branch.md | 11 +++++++++++ apps/readest-app/.claude/skills/gstack | 2 +- 4 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 apps/readest-app/.claude/memory/feedback_gstack_upgrade.md create mode 100644 apps/readest-app/.claude/memory/feedback_pr_new_branch.md diff --git a/apps/readest-app/.claude/memory/MEMORY.md b/apps/readest-app/.claude/memory/MEMORY.md index 5710de19..0a7dc282 100644 --- a/apps/readest-app/.claude/memory/MEMORY.md +++ b/apps/readest-app/.claude/memory/MEMORY.md @@ -27,3 +27,5 @@ ## Workflow - [Always rebase before PR](feedback_pr_rebase.md) — rebase onto origin/main before creating PRs +- [New branch per PR](feedback_pr_new_branch.md) — always create a fresh branch from main for each new PR/issue +- [Upgrade gstack locally](feedback_gstack_upgrade.md) — always upgrade from the project's .claude/skills/gstack, not global diff --git a/apps/readest-app/.claude/memory/feedback_gstack_upgrade.md b/apps/readest-app/.claude/memory/feedback_gstack_upgrade.md new file mode 100644 index 00000000..ede2ef9b --- /dev/null +++ b/apps/readest-app/.claude/memory/feedback_gstack_upgrade.md @@ -0,0 +1,11 @@ +--- +name: gstack upgrade location +description: Always upgrade gstack from the project directory (.claude/skills/gstack), not from a global install +type: feedback +--- + +When upgrading gstack, always run the upgrade from the current project's `.claude/skills/gstack` directory (local-git install), not from a global install path. + +**Why:** The project uses a local-git gstack install at `apps/readest-app/.claude/skills/gstack`. Previous mistakes upgraded a global copy while the project's local copy stayed outdated. + +**How to apply:** When `/gstack-upgrade` is invoked, ensure the `cd` and `git reset --hard origin/main && ./setup` happen inside the project's `.claude/skills/gstack` directory. diff --git a/apps/readest-app/.claude/memory/feedback_pr_new_branch.md b/apps/readest-app/.claude/memory/feedback_pr_new_branch.md new file mode 100644 index 00000000..bb60d0b1 --- /dev/null +++ b/apps/readest-app/.claude/memory/feedback_pr_new_branch.md @@ -0,0 +1,11 @@ +--- +name: Always use a new branch for new PRs +description: Each new PR/issue should get its own fresh branch from main, never reuse an existing feature branch +type: feedback +--- + +Always create a new branch from main for each new PR or issue. Never reuse an existing feature branch for unrelated work. + +**Why:** The user corrected this when a storage fix was committed on the `feat/full-sync-annotations` branch instead of a dedicated branch. Mixing unrelated changes on the same branch makes PRs harder to review and manage. + +**How to apply:** Before committing fixes, create a new branch like `fix/` from `origin/main`. Only reuse a branch if the work is directly related to that branch's existing purpose. diff --git a/apps/readest-app/.claude/skills/gstack b/apps/readest-app/.claude/skills/gstack index 1f4b6fd7..6169273d 160000 --- a/apps/readest-app/.claude/skills/gstack +++ b/apps/readest-app/.claude/skills/gstack @@ -1 +1 @@ -Subproject commit 1f4b6fd7a2a349dfc6f04d158b8b7778b5b74232 +Subproject commit 6169273d16b7ab8690943241fa802e5a1ca85305