readest/apps/readest-app/.claude/memory/koplugin-cover-upload.md at 4af203755d807ae317c9ffe4922f5f1e7989a66b

Files

T

Huang Xin 3a81e09911 fix(reader): scroll oversized blocks in-place instead of turning the page (#4400 ) (#4415 )

Wide or tall tables, code blocks and display equations overflowed the reading
column and a scroll gesture over them turned the page instead of scrolling the
content (#4400).

- Wrap tables and display equations in a horizontally/vertically scrollable
  container; route touch + wheel along the box's scrollable axis so it scrolls
  the box and never turns the page, even at the edge (both axes).
- A box that fits its column is marked fit (overflow:visible) so it never clips
  or captures gestures; the fit decision is measured once after layout via a
  self-disconnecting ResizeObserver, so it never relayerizes during a page turn.
- The scroll wrapper carries a new cfi-skip attribute that makes it transparent
  to CFI: epubcfi.js hoists a cfi-skip node's children into its parent (unlike
  cfi-inert which drops the subtree), and xcfi.ts mirrors this for CFI<->XPointer
  so existing highlights, bookmarks and KOSync positions inside a wrapped table
  or equation still resolve. The sanitizer whitelists cfi-skip.
- Bump foliate-js submodule (cfi-skip support + raf fallback for large sections).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-02 14:45:18 +02:00

2.1 KiB

Raw Blame History

name, description, metadata

name

description

metadata

koplugin-cover-upload

koplugin cover system — where local/cloud covers come from, and the

node_type	type	originSessionId
memory	reference	95cdff70-ce2c-4077-82a8-922f9578a22f

readest.koplugin cover handling (in apps/readest.koplugin/library/):

Local book covers come from coverbrowser.koplugin's BookInfoManager (a hard dependency). coverprovider.get_local_cover(file_path) returns BIM:getBookInfo(file_path, true).cover_bb (a downscaled thumbnail bb) and kicks off background extraction on a miss.
Native-resolution cover for a file (no open doc needed): require("apps/filemanager/filemanagerbookinfo"):getCoverImage(nil, file_path) — opens+closes the doc itself, honors KOReader custom covers, returns a blitbuffer. Same (nil, file) call form calibre.koplugin uses. Write it to PNG with bb:writeToFile(path, "png") (pcall-wrapped internally) then bb:free().
Cloud covers are downloaded to DataStorage:getSettingsDir()/readest_covers/<hash>.png (cloud_covers.covers_dir()); cloud storage key is <user_id>/Readest/Books/<hash>/cover.png (build_cover_key), which matches readest's getCoverFilename (<hash>/cover.png).

Issue #4374 (fixed): syncbooks.uploadBook only shipped a cover.png if one was already cached under readest_covers/<hash>.png from a prior cloud download — so books that originated locally in KOReader uploaded with no cover and showed blank in readest. Fix = syncbooks.extractLocalCover(file_path, dst_png) (extracts via getCoverImage → writeToFile), called from uploadBook when has_cover is false. Only file-upload path is librarywidget.lua "Upload to Cloud" → uploadBook (FileManager addToReadest only stages a local row).

Tests: network/live parts of syncbooks.lua aren't unit-tested (manual matrix in docs/library-design.md); extractLocalCover IS tested by injecting a fake apps/filemanager/filemanagerbookinfo via package.loaded in spec/library/syncbooks_spec.lua. A real KOReader checkout lives at /Users/chrox/dev/koreader for verifying KOReader APIs. See koplugin-i18n.

2.1 KiB Raw Blame History

2.1 KiB

Raw Blame History