Huang Xin
3a81e09911
Wide or tall tables, code blocks and display equations overflowed the reading column and a scroll gesture over them turned the page instead of scrolling the content (#4400). - Wrap tables and display equations in a horizontally/vertically scrollable container; route touch + wheel along the box's scrollable axis so it scrolls the box and never turns the page, even at the edge (both axes). - A box that fits its column is marked fit (overflow:visible) so it never clips or captures gestures; the fit decision is measured once after layout via a self-disconnecting ResizeObserver, so it never relayerizes during a page turn. - The scroll wrapper carries a new cfi-skip attribute that makes it transparent to CFI: epubcfi.js hoists a cfi-skip node's children into its parent (unlike cfi-inert which drops the subtree), and xcfi.ts mirrors this for CFI<->XPointer so existing highlights, bookmarks and KOSync positions inside a wrapped table or equation still resolve. The sanitizer whitelists cfi-skip. - Bump foliate-js submodule (cfi-skip support + raf fallback for large sections). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2.7 KiB
2.7 KiB
name, description, metadata
| name | description | metadata | ||||||
|---|---|---|---|---|---|---|---|---|
| window-state-sanitize-4398 | Windows launch crash (WebView2 0x80070057) from invalid .window-state.json; defensive sanitizer plugin |
|
Issue #4398 (PR #4401) — Windows app fails to launch ("WebView2 error 0x80070057 / The parameter is incorrect") when %APPDATA%\com.bilingify.readest\.window-state.json holds the minimized sentinel (x/y = -32000) or 0×0 size.
Non-obvious facts:
- Our
tauri-plugin-window-state(2.4.1, and every shipped 2.2.1+) ALREADY contains the upstream fix for tauri-apps/plugins-workspace#253:update_state+ the Moved/Resized handlers skip saving whileis_minimized(), and restore only re-applies position if itintersects()a monitor. So current builds shouldn't generate bad state — a bad file is almost certainly stale from an old build. The version-inquiry comment is on the issue. - Fix = defense-in-depth, NOT a behavior change:
src-tauri/src/window_state.rs— a tinywindow-state-sanitizerTauri plugin whosesetupstrips window entries with invalid geometry (width<=0 || height<=0 || x<=-30000 || y<=-30000) from the file before window-state reads it. Puresanitize_json(&str)->Option<String>is unit-tested (cargo test -p Readest window_state). - Plugin init order matters: Tauri's
PluginStore::initialize_alliterates the store in registration order (Vec push), and window-state loads the file in itssetup(runs duringinitialize). So the sanitizer plugin MUST be registered BEFOREtauri_plugin_window_stateinlib.rs(it is). The app-level.setup()closure runs AFTER all plugin setups → too late to sanitize there. - Coord threshold is
-16000(sentinel is exactly-32000; ~halfway). Real desktops sit a few thousand px off origin (4K-left =-3840, 3×4K ≈-11520), so-16000is well past normal use yet clearly the sentinel zone; a legit negative like-1920is kept. Do NOT justify by extreme N-monitor walls (user pushed back on that). The size check (<=0) is the real WebView2-crash guard; this coord check is secondary (the plugin already refuses to restore an off-screen position via itsintersects()monitor check). Missing fields default to valid so a schema change never drops a good entry.
Repo Rust testing reality: zero pre-existing #[cfg(test)] modules; CI only runs cargo fmt --check + cargo clippy -p Readest --no-deps -D warnings (NOT --all-targets, so it won't compile test code). generate_context! tolerates a missing frontendDist (../out), so cargo test/clippy build without a frontend build. See tauri-parser-parity-tests.