Files
readest/apps/readest-app/src/__tests__/components/TOCView.test.tsx
T
loveheaven 59d4f0aa33 perf(reader): split progress into its own store to cut React commit storm (#4557)
setProgress was called multiple times per swipe burst, each call writing
into readerStore.viewStates[key].progress. ~65 places in the reader
subtree subscribed to useReaderStore() without a selector, so every
setProgress fan-out re-rendered all of them -- even the 51 that didn't
care about progress. On Android release builds this showed up as
Layout = 9.8% and Function Call = 9.6% of main-thread self time in
Chrome DevTools' Bottom-Up profile during a reading session.

Fix:
- New tiny store store/readerProgressStore.ts holds the per-book
  BookProgress map. setBookProgress only fires its own subscribers.
- readerStore.setProgress now writes progress to the new store and only
  touches bookDataStore for the primary view (secondary parallel views
  shouldn't overwrite the shared config).
- readerStore.getProgress is kept as a delegating facade so existing
  imperative call sites don't break.
- Components / hooks that genuinely need to react to progress changes
  subscribe via the new useBookProgress(bookKey) hook. The handful of
  call sites that just want a one-shot read use getBookProgress(key) so
  they don't subscribe at all.
- readerStore.clearViewState calls clearBookProgress so the map doesn't
  grow unbounded across book opens/closes.

See store/readerProgressStore.ts header for the full rationale.
2026-06-12 17:14:49 +02:00

150 lines
5.1 KiB
TypeScript

import { render, act, cleanup } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it, vi, type Mock } from 'vitest';
import type { TOCItem } from '@/libs/document';
// ---------- Shared mutable test state (captured by the mock factories) ----------
let scrollToIndexSpy: Mock<(arg: unknown) => void>;
// Only the FIRST (mount-time) `initialized` callback is captured, mirroring how
// OverlayScrollbars binds its event handlers when it initializes the viewport.
// A fix that relied on a fresher render closure would pass against the latest
// callback but still break in the real app — so the test forces a ref-based fix.
let capturedInitialized:
| ((instance: { elements: () => { viewport: HTMLElement } }) => void)
| undefined;
let mockProgress: { sectionHref: string; location: string } | null;
// ---------- Mocks ----------
vi.mock('@/store/readerStore', () => {
const state = {
getView: () => undefined,
getViewSettings: () => ({ isEink: false }),
getProgress: () => mockProgress,
};
return {
useReaderStore: <R,>(selector?: (s: typeof state) => R) => (selector ? selector(state) : state),
};
});
vi.mock('@/store/sidebarStore', () => ({
useSidebarStore: () => ({ sideBarBookKey: 'book1', isSideBarVisible: true }),
}));
vi.mock('@/services/nav', () => ({ findParentPath: () => [] }));
vi.mock('@/utils/event', () => ({
eventDispatcher: { dispatch: vi.fn(), on: vi.fn(), off: vi.fn() },
}));
vi.mock('@/utils/misc', () => ({ getContentMd5: (s: string) => s }));
vi.mock('@/app/reader/hooks/useTextTranslation', () => ({
useTextTranslation: () => {},
}));
// Virtuoso is replaced with a stub that exposes a spy-able `scrollToIndex`
// through the imperative handle and hands TOCView a scroller element.
vi.mock('react-virtuoso', async () => {
const ReactMod = await import('react');
return {
Virtuoso: ReactMod.forwardRef(
(
props: { scrollerRef?: (el: HTMLElement | Window | null) => void },
ref: React.Ref<unknown>,
) => {
ReactMod.useImperativeHandle(ref, () => ({
scrollToIndex: (arg: unknown) => scrollToIndexSpy(arg),
}));
ReactMod.useEffect(() => {
props.scrollerRef?.(document.createElement('div'));
}, []);
return null;
},
),
};
});
// Capture the OverlayScrollbars `initialized` callback so the test can fire it
// on demand (the real hook fires it after a deferred, timing-dependent init).
vi.mock('overlayscrollbars-react', () => ({
useOverlayScrollbars: (opts: {
events?: { initialized?: (i: { elements: () => { viewport: HTMLElement } }) => void };
}) => {
if (!capturedInitialized) capturedInitialized = opts.events?.initialized;
return [vi.fn(), () => undefined];
},
}));
// eslint-disable-next-line import/first
import TOCView from '@/app/reader/components/sidebar/TOCView';
const makeFlatToc = (count: number): TOCItem[] =>
Array.from({ length: count }, (_, i) => ({
id: i + 1,
label: `Chapter ${i}`,
href: `ch${i}.html`,
index: i,
}));
const fireOverlayScrollbarsInitialized = () => {
act(() => {
capturedInitialized?.({ elements: () => ({ viewport: document.createElement('div') }) });
});
};
beforeEach(() => {
scrollToIndexSpy = vi.fn<(arg: unknown) => void>();
capturedInitialized = undefined;
mockProgress = null;
// Run rAF synchronously so the callback's scroll happens inside act().
vi.stubGlobal('requestAnimationFrame', (cb: FrameRequestCallback) => {
cb(0);
return 0;
});
});
afterEach(() => {
cleanup();
vi.unstubAllGlobals();
});
describe('TOCView — OverlayScrollbars init does not rewind the TOC to the top', () => {
it('re-applies the auto-scroll to the active item when OverlayScrollbars initializes after the reading position arrives', () => {
const toc = makeFlatToc(8);
const activeHref = 'ch5.html';
// Fresh refresh: TOCView mounts before the first relocate, so `progress`
// (and thus the mount-time initialScrollTarget) has no reading position.
mockProgress = null;
const { rerender } = render(<TOCView bookKey='book1' toc={toc} />);
// The relocate arrives → the normal auto-scroll effect centers the active
// chapter. (OverlayScrollbars' deferred init, which resets scrollTop to 0,
// has not fired yet.)
mockProgress = { sectionHref: activeHref, location: 'epubcfi(/6/12!/4/1:0)' };
act(() => {
rerender(<TOCView bookKey='book1' toc={toc} />);
});
// Ignore that first scroll; we only care whether the OverlayScrollbars init
// (which clobbers scrollTop) re-applies it instead of stranding the top.
scrollToIndexSpy.mockClear();
fireOverlayScrollbarsInitialized();
expect(scrollToIndexSpy).toHaveBeenCalledWith(expect.objectContaining({ index: 5 }));
});
it('does not force a scroll on OverlayScrollbars init when there is no reading position', () => {
const toc = makeFlatToc(8);
mockProgress = null;
render(<TOCView bookKey='book1' toc={toc} />);
scrollToIndexSpy.mockClear();
fireOverlayScrollbarsInitialized();
expect(scrollToIndexSpy).not.toHaveBeenCalled();
});
});