ed8956e9ed
* feat(koplugin/library): data layer + busted harness + design doc - LibraryStore: per-user SQLite index merging cloud + local books by partial-md5 hash. listBooks/listBookshelfBooks/listBookshelfGroups, upsertBook with cloud_present/local_present OR-merge + _force/clear sentinels, parseSyncRow, getChangedBooks for tombstone push. - EXTS table mirroring web's document.ts. - busted harness with KOReader stubs (G_reader_settings, DataStorage, lua-ljsqlite3 against :memory:); spec_helper, exts_spec, smoke_spec, librarystore_spec covering schema, sort, group nesting, dedupe. - Library design doc + spec README. - pnpm test:lua wired through root + app package.json; lint-koplugin recurses into library/ + spec/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(koplugin/library): cloud sync — push, pull, upload, delete, downloads - Spore methods: pullBooks (incremental /sync), getDownloadUrl, getUploadUrl, listFiles, deleteFile. - syncbooks.lua: pushBook + pushChangedBooks (advances watermark to max(updated_at, deleted_at)), syncBooks(opts, mode) for push/pull/both, downloadBook + downloadCover (sync socket.http with file sink; cover download via fork+poll with single-slot queue + visible-page filter + coalesced refresh), uploadBook (presigned-PUT flow + best-effort cover), deleteCloudFiles (list-then-delete-each, mirrors cloudService.deleteBook). - SyncAuth.withFreshToken wrapper resolves the ensureClient race; 401/403 unified across syncconfig + syncannotations. - Cloud + local book covers shared by partial-md5 hash; cover.png cached at <settings>/readest_covers/<hash>.png with sentinel for known 404s. - syncbooks_spec covers row-to-wire conversion + file_key shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(koplugin/library): local discovery — sidecar scanner + cover provider - localscanner.lightScan iterates ReadHistory entries, reads partial_md5_checksum from .sdr sidecars, and upserts local rows. Slow filesystem walks deferred to fullSidecarWalk (24h-gated). - coverprovider wraps BookInfoManager:getBookInfo for local books with graceful FakeCover fallback when coverbrowser is absent. - localscanner_spec + coverprovider_spec. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(koplugin/library): UI — widget, item, view menu, FileManager hooks - librarywidget: full-screen Menu mixed in with CoverMenu + Mosaic/List per zen_ui's group_view pattern. Title-bar tap → view menu, search via left icon, drill-in/back for grouping. Async cloud sync deferred via scheduleIn so the menu paints before HTTP fires. - libraryitem: BIM patch for cloud-only (readest-cloud://) and group (readest-group://) URIs; group-cover composer (2x2 mosaic for grid, same in list) with cache key derived from the actual first-N hashes for content-based invalidation; ListMenuItem update + paintTo patches for wider list-mode cover strip and cloud-up/down icon overlay. - libraryviewmenu: ButtonDialog with View/Group by/Sort by/Actions. Default Group by = Groups (parity with web), values authors/groups. - librarypaint: partial-page e-ink repaint shim adapted from zen_ui. - main.lua: Library menu entry, dispatcher actions (Open Library / Push / Pull as general; progress + annotations as reader-only), "Add to Readest" button in FileManager's long-press file dialog (dedupe by partial_md5; bumps updated_at when present, inserts a fresh local-only row otherwise; un-tombstones via _clear_fields). Push books on Library open when auto_sync is on, pull-only otherwise. - Long-press action sheet with Readest BookDetailView parity: Remove from Cloud & Device / Cloud Only / Device Only, Upload to Cloud, Download Book / Cover / All. - Cloud-down + cloud-up SVG icons (LiaCloudDownloadAltSolid / LiaCloudUploadAltSolid) painted in the right-side wpageinfo slot. - i18n catalog updated for new strings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(koplugin/library): split libraryitem into focused modules libraryitem.lua had grown to 1018 lines mixing five unrelated concerns. Split along the natural seams: cloud_covers — readest-cloud:// URI scheme, on-disk <hash>.png cache, single-slot async download queue, visible-page filter group_covers — readest-group:// URI scheme, 2x2 mosaic composer with content-derived cache key (first-N hashes), cell layout table cloud_icons — bundled cloud-up/cloud-down SVG loader, IconWidget cache, paint-overlay positioning list_strip — list-mode group row builder (4-cover wider strip replacing ListMenu's square cover slot) bim_patch — BookInfoManager:getBookInfo router (cloud / group / local) + ListMenuItem update + paintTo patches; owns the _library_local_paths set and orig BIM reference libraryitem.lua is now 141 lines: just the entry-table constructors (entry_from_row, entry_from_group, entry_back) plus thin install / set_visible_hashes delegates. Each new module is 88-216 lines. No behavior change — same 113 specs pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(koplugin): co-locate dev tooling, ship-zip exclusions, CI job split - apps/readest.koplugin/scripts/build-koplugin.mjs: local sideloading build with the same exclusions the release workflow uses. - Move lint-koplugin + test-koplugin from apps/readest-app/scripts/ to apps/readest.koplugin/scripts/. All koplugin dev tooling now lives with the koplugin and is excluded from the published release zip. - Rename to .mjs so Node treats them as ESM without the reparse warning (the i18n CommonJS scripts stay .js). - Release workflow: zip -r exclusions for scripts/, docs/, spec/, .busted so dev artifacts don't ship to end users. - PR workflow: split build_web_app into build_web_app + test_web_app for parallelism. The test job installs luarocks + busted + lsqlite3complete and runs pnpm test:lua. test-koplugin.mjs now hard-fails (instead of soft-skipping) when CI=true and a tool is missing — a broken CI toolchain previously exited 0 silently. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
82 lines
2.7 KiB
Lua
82 lines
2.7 KiB
Lua
-- smoke_spec.lua
|
|
-- Minimal sanity check that the busted harness + spec_helper are wired up.
|
|
-- If this passes we know:
|
|
-- 1. busted finds spec files via .busted ROOT/pattern
|
|
-- 2. spec_helper preloads run (KOReader stubs available globally)
|
|
-- 3. The lua-ljsqlite3/init shim works against an in-memory SQLite DB
|
|
-- Other spec files can then assume all of the above.
|
|
|
|
local helper = require("spec_helper")
|
|
|
|
describe("spec harness smoke test", function()
|
|
before_each(function()
|
|
helper.reset()
|
|
end)
|
|
|
|
it("runs at all", function()
|
|
assert.are.equal(4, 2 + 2)
|
|
end)
|
|
|
|
it("exposes G_reader_settings as a global", function()
|
|
assert.is_not_nil(_G.G_reader_settings)
|
|
G_reader_settings:saveSetting("hello", "world")
|
|
assert.are.equal("world", G_reader_settings:readSetting("hello"))
|
|
end)
|
|
|
|
it("reset wipes G_reader_settings between tests", function()
|
|
assert.is_nil(G_reader_settings:readSetting("hello"))
|
|
end)
|
|
|
|
it("DataStorage:getSettingsDir() returns a usable temp dir", function()
|
|
local DataStorage = require("datastorage")
|
|
local dir = DataStorage:getSettingsDir()
|
|
assert.is_string(dir)
|
|
assert.is_truthy(dir:match("^/tmp/readest%-koplugin%-spec%-"))
|
|
-- Confirm we can write into it
|
|
local f = assert(io.open(dir .. "/probe.txt", "w"))
|
|
f:write("ok")
|
|
f:close()
|
|
local r = assert(io.open(dir .. "/probe.txt", "r"))
|
|
assert.are.equal("ok", r:read("*a"))
|
|
r:close()
|
|
end)
|
|
|
|
it("opens an in-memory SQLite via the lua-ljsqlite3 shim", function()
|
|
local SQ3 = require("lua-ljsqlite3/init")
|
|
local db = SQ3.open(":memory:")
|
|
db:exec([[
|
|
CREATE TABLE t (id INTEGER PRIMARY KEY, name TEXT);
|
|
INSERT INTO t (id, name) VALUES (1, 'alpha'), (2, 'beta');
|
|
]])
|
|
|
|
-- rowexec helper
|
|
assert.are.equal(2, db:rowexec("SELECT COUNT(*) FROM t"))
|
|
|
|
-- prepare/bind/step round-trip
|
|
local sel = db:prepare("SELECT name FROM t WHERE id = ?")
|
|
local row = sel:reset():bind1(1, 1):step()
|
|
assert.is_table(row)
|
|
assert.are.equal("alpha", row[1])
|
|
|
|
row = sel:reset():bind1(1, 2):step()
|
|
assert.are.equal("beta", row[1])
|
|
|
|
-- step returns nil after exhausting matches
|
|
local none = sel:reset():bind1(1, 999):step()
|
|
assert.is_nil(none)
|
|
|
|
sel:close()
|
|
db:close()
|
|
end)
|
|
|
|
it("logger stub is silently callable", function()
|
|
local logger = require("logger")
|
|
assert.has_no.errors(function()
|
|
logger.warn("a warning")
|
|
logger.info("an info")
|
|
logger.dbg("debug")
|
|
logger.err("an error")
|
|
end)
|
|
end)
|
|
end)
|