The KOReader plugin's incremental books pull went permanently stale: after
a while it stopped receiving any updates made from other devices, and only
deleting readest_library.sqlite3 + "Pull books now" recovered it (until it
re-broke). The iOS/web library was unaffected.
Root cause: since #4678 the server keys the books pull on the server-stamped
synced_at column, and the web client (computeMaxTimestamp) advances its
cursor from synced_at. The koplugin was left on updated_at: pullBooks
advanced last_books_pulled_at from max(updated_at, deleted_at). updated_at
is client-supplied, and the koplugin bumps it from the device clock
(touchBook = os.time()*1000). An e-reader clock ahead of the server (or any
row anywhere carrying a future updated_at) drove the cursor past server-now,
so the server's synced_at > since filter returned nothing forever.
The cursor was also shared between the pull side (compared vs server
synced_at) and push-delta detection (getChangedBooks vs local updated_at),
so it could not simply be retargeted.
Fix:
- parseSyncRow reads synced_at; new row_pull_cursor() prefers it and falls
back to max(updated_at, deleted_at) for a pre-synced_at server, mirroring
computeMaxTimestamp.
- Split the cursor: last_books_pulled_at now tracks server synced_at (pull
only); new last_books_pushed_at tracks local updated_at for getChangedBooks
and is advanced on both pull and push, preserving push dedup.
- v2 -> v3 migration seeds the push watermark from the old shared value and
resets the pull cursor to 0, auto-healing already-stale installs with one
full re-pull (no manual sqlite deletion) and no re-push storm.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Huang Xin
0b180da6a6