akai-tools/readest
2
0
Fork 0
forked from akai/readest
Code Pull Requests Activity

fix(reader): keep Android paginated text selection from jumping back to first rendered section (#4342)

Browse Source 
The Android-only workaround that pinned the container scroll while text was
selected saved `renderer.start` (section-relative) and restored it as
`renderer.containerPosition` (absolute). On later sections those two
diverge — restoring the small `start` value as `containerPosition` snapped
the multi-view scroll back to the first rendered section whenever the OS
selection handle drag triggered a scroll. Save and restore the same
`containerPosition` value instead.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Huang Xin
2026-05-28 23:07:49 +08:00
committed by GitHub
parent e29331bea9
commit bb81d6270f
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/readest-app/src/app/reader/hooks/useTextSelector.ts
+7 -4
View File
@@ -189,8 +189,12 @@ export const useTextSelector = (
const sel = doc.getSelection() as Selection;
if (isValidSelection(sel)) {
if (!selectionPosition.current) {
selectionPosition.current = view?.renderer?.start || null;
if (selectionPosition.current === null) {
// Save the absolute container scroll, not `renderer.start` — the
// latter is section-relative, so restoring it as `containerPosition`
// snaps multi-section paginated views back to the first rendered
// section (#873-related Android regression).
selectionPosition.current = view?.renderer?.containerPosition ?? null;
}
makeSelection(sel, index, false);
} else {
@@ -206,8 +210,7 @@ export const useTextSelector = (
const viewSettings = getViewSettings(bookKey);
if (viewSettings?.scrolled) return;
if (isTextSelected.current && view?.renderer?.containerPosition && selectionPosition.current) {
console.warn('Keep container position', selectionPosition.current);
if (isTextSelected.current && view?.renderer && selectionPosition.current !== null) {
view.renderer.containerPosition = selectionPosition.current;
}
};